Re: errata/113: generate

From: Shalom.Bresticker@freescale.com
Date: Wed May 05 2004 - 04:30:00 PDT

  • Next message: Jason Woolf: "Re: enhancement/17: 12.1.3 is not clear enough about permitted defparam usage"

    The following reply was made to PR errata/113; it has been noted by GNATS.

    From: Shalom.Bresticker@freescale.com
    To: etf-bugs@boyd.com
    Cc:
    Subject: Re: errata/113: generate
    Date: Wed, 5 May 2004 14:48:12 +0300 (IDT)

     The following are the edits I am making to the generate proposal,
     based on the April 5 ETF mmeting minutes, as follows:
     
    > From the email vote on the generate proposal:
    > The generate proposal passed. Shalom had comments. Stu
    > opposed on the basis of more discussion required.
    >
    > Steven moves that we ammend the passed generate proposal in the
    > following way:
    > In the new proposal:
    >
    > - In 12.4.1, Example 2, on the line
    >
    > assign bin[i] = ^gray[SIZE-1:i];
    >
    > add a comment as follows:
    >
    > // i refers to the implicitly defined localparam whose value in each instance
    > // of the generate block is the value of the genvar when it was elaborated.
     
     Done.
     
     
    > - On page 12 of the new text pdf (section 12.4.2), change
    > the name of the gate from test.u1.x1, to test.u1.g1.
     
     
     Done.
     
     
    > Charles seconds. No opposed. No abstain. Passes.
     
    > Cliff's concerns:
    > 12.4.1:
    > Make the example 1 more complete by wrapping a module
    > declarations and genvar i declarations around them,
    > so it isn't code snippets any more. 3 modules.
    >
    > Add a comment that generate..endgenerate is no longer
    > required.
     
     OK.
     
     
    > Page 12:
    > Should the example have a number? The committee
    > agrees it should. Also add comments, as indicated in
    > Cliff's attached document:
    >
    > http://boydtechinc.com/etf/archive/att-2437/02_Example_12_4_2_formatted.pdf
     
     This will be Example 6. The example numbers of the examples following this one
     in 12.4 will be incremented by 1.
     
     I will change the instance comments to something like:
     
     if (q == 0) begin : u1 // if p is 1 and q is 0 then instantiate an and
       and g1 (a, b, c); // gate with hierarchical instance name test.u1.g1
     
     
    > Page 15:
    > Add an example number... And update formatting
    > according to Cliff's attached document:
    >
    > http://boydtechinc.com/etf/archive/att-2437/03_Example_12_4_3_formatted.pdf
    > The comment about genblk3 is incorrect because genblk3
    > is named.
    >
    > Francoise will modify the example in 12_4_3 to have
    > it more accurately reflect what was intended.
     
     This will be Example 10.
     I will use Francoise's revised version.
      
     
    > Page 16: "Each such" seems awkward...
     
     No change.
     
     
    > "refer instance arrays" should be "refer to instance
    > arrays"
     
     OK.
     
     
    > Page 19: The scope searching algorithm needs to be
    > rewritten.
    > Steven took the action item to do that.
     
     No change. Issue #570.
     
     
    > Page 20: A little indentation would help the
    > examples.
     
     Instead of indentation, I will add some blank lines, e.g,
     
     module a;
     integer i;
     
     b a_b1();
     
     endmodule
     
     
    > Page 21: Reword sentence starting "If an identifier
    > is referenced directly"
    > Steven took the action item to do that.
     
     No change. Issue #570.
     
    >
    > 12.7 Consider changing example spacing.
     
     As discussed in issue #334, the example needs to be rewritten.
     The text refers to an "incompletely defined downward reference",
     but there is no downward reference, and the term "incompletely
     defined" is itself not defined. If you are looking at the version
     with a comment about redundant assignments, that is also incorrect.
     The t.b.r reference is illegal and t.s is not a downward reference.
     So I intend to simply delete the example until someone suggests
     something better. As I said, this is issue #334 in the databse, so it
     should not be forgotten.
     
     
    > Given the number of changes recommended above, the committee
    > agreed to update the document with the changes passed and
    > discussed today. We should also vote on the amended document.
    >
    > The amendments that need to happen are:
    >
    > 1) The two typos Shalom had indicated that we passed this
    > meeting.
     
     Done.
     
      
    > 2) Address Cliff's issues
    > a) the first example in 12.4.1
    >
    > b) update the example on page 12 with Cliff's update
    >
    > c) use Francoise's update to the example in 12.4.3
    >
    > d) address "refer instance arrays" typo
     
     a to d: OK
     
      
    > e) Add Steven's rewrite on page 19
    >
    > f) Add Steven's rewrite on page 21
     
     e,f: No change.
     
     
     Other changes I am making:
     
     P. 1: In 3.10.1, change cross-reference from 12.4 to 12.4.1.
     
     Some font and upper vs. lower case corrections.
     
     Shalom
     

    This archive was generated by hypermail 2.1.4 : Wed May 05 2004 - 04:30:11 PDT and
    sponsored by Boyd Technology, Inc.